Using ResultSet.next() loop for collecting query result data.

thesquaregroot · thesquaregroot · commit d51a4eae2fe2 · 2023-02-22T17:10:47.000-05:00
diff --git a/src/main/java/com/softwareverde/database/jdbc/JdbcDatabaseConnection.java b/src/main/java/com/softwareverde/database/jdbc/JdbcDatabaseConnection.java
@@ -105,18 +105,8 @@ protected List<Row> _query(final String query, final TypedParameter[] typedParam
             try (final PreparedStatement preparedStatement = _prepareStatement(query, typedParameters);
                  final ResultSet resultSet = preparedStatement.executeQuery() ) {
 
-                boolean shouldIterate;
-                if (resultSet.getType() == ResultSet.TYPE_FORWARD_ONLY) {
-                    shouldIterate = resultSet.next();
-                }
-                else {
-                    shouldIterate = resultSet.first();
-                }
-
-                if (shouldIterate) {
-                    do {
-                        results.add(_rowFactory.fromResultSet(resultSet));
-                    } while (resultSet.next());
+                while (resultSet.next()) {
+                    results.add(_rowFactory.fromResultSet(resultSet));
                 }
             }
             return results;
