Skip to content

Update ruling results for PR #6704#6727

Merged
francois-mora-sonarsource merged 1 commit intofix/JS-1391-fix-fp-on-s6767-props-reported-unused-when-component-is-wrapped-and-exported-via-an-hoc-sonnetfrom
fix/update-ruling-for-fix/JS-1391-fix-fp-on-s6767-props-reported-unused-when-component-is-wrapped-and-exported-via-an-hoc-sonnet
Apr 1, 2026
Merged

Update ruling results for PR #6704#6727
francois-mora-sonarsource merged 1 commit intofix/JS-1391-fix-fp-on-s6767-props-reported-unused-when-component-is-wrapped-and-exported-via-an-hoc-sonnetfrom
fix/update-ruling-for-fix/JS-1391-fix-fp-on-s6767-props-reported-unused-when-component-is-wrapped-and-exported-via-an-hoc-sonnet

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Auto-generated ruling update for PR #6704.

🤖 Generated with GitHub Actions

🤖 Generated with GitHub Actions
@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha bot commented Mar 31, 2026

Summary

Updates expected violations for rule S6767 (unused props/parameters) following the fix in PR #6704 that corrects false positives when components are wrapped and exported via HOC. Three new violation locations are recorded: EnumBox.tsx (lines 23, 27, 28), TypeBox.tsx (line 25), and NewNodeRow.tsx (line 20). This represents the adjusted expected behavior after improved HOC handling.

What reviewers should know

This is an auto-generated ruling update — a single test expectations file reflecting the impact of the S6767 rule fix from PR #6704. No source code changes here; verify the PR #6704 fix for the actual rule logic changes. The new violations in the expectations file should align with patterns of the HOC-wrapped component issue that was being fixed. If reviewing this alongside PR #6704, check that the violations added here correspond to cases that were previously false positives and are now correctly identified.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

This is a clean auto-generated ruling update — only the expected violations file for S6767 is touched, with three new test locations added that reflect the corrected rule behavior from PR #6704.

🗣️ Give feedback

@francois-mora-sonarsource francois-mora-sonarsource merged commit 6ae307e into fix/JS-1391-fix-fp-on-s6767-props-reported-unused-when-component-is-wrapped-and-exported-via-an-hoc-sonnet Apr 1, 2026
2 checks passed
@francois-mora-sonarsource francois-mora-sonarsource deleted the fix/update-ruling-for-fix/JS-1391-fix-fp-on-s6767-props-reported-unused-when-component-is-wrapped-and-exported-via-an-hoc-sonnet branch April 1, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant