Adapt to https://github.com/rocq-prover/rocq/pull/21609#2066
Open
proux01 wants to merge 1 commit intoUniMath:masterfrom
Open
Adapt to https://github.com/rocq-prover/rocq/pull/21609#2066proux01 wants to merge 1 commit intoUniMath:masterfrom
proux01 wants to merge 1 commit intoUniMath:masterfrom
Conversation
Merged
5 tasks
benediktahrens
requested changes
Jan 27, 2026
Member
benediktahrens
left a comment
There was a problem hiding this comment.
@proux01 : thanks a lot for preparing this PR.
There seem to be some unintended changes, that need to be reverted. I have not checked everything carefully yet.
Contributor
Author
|
I tried to catch most of them, but due to the extent of the change a few mistakes indeed slept in. Hopefully, there shouldn't be too many remaining now. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to rocq-prover/rocq#21478
(the choice of
iscis a bit arbitrary, we could go for anything else, just notis)