Conversation
# Conflicts: # weedcoco/validation.py
jnothman
left a comment
There was a problem hiding this comment.
A squiz at overall structure.
| ] | ||
| validate_json.ref_store = {obj["$id"]: obj for obj in schema_objects} | ||
| ref_store = validate_json.ref_store | ||
| schema_uri = MAIN_SCHEMAS[schema] |
There was a problem hiding this comment.
This is an incorrect merge resolution
| # TODO | ||
|
|
||
|
|
||
| def validate(weedcoco, images_root=None, schema="weedcoco"): |
There was a problem hiding this comment.
This is an incorrect merge resolution
| import cv2 | ||
| import os | ||
|
|
||
| visualisation = True |
There was a problem hiding this comment.
We should make this a command-line arg on all importers if we wish it to be most useful.
| @@ -0,0 +1,30 @@ | |||
| @echo off | |||
There was a problem hiding this comment.
not sure we want this file in the repo
There was a problem hiding this comment.
Yeh wasn't sure about that, I didn't realise they could be potentially nasty files. Will remove.
There was a problem hiding this comment.
I don't think it's nasty, but it's a bit too specific for most users, while something like the README should be reasonably accessible???
| ap.add_argument("--labelbox-json", required=True, type=str, help='path to downloaded labelbox JSON file') | ||
| ap.add_argument("--save-dir", required=True, type=str) | ||
| ap.add_argument("--keep-original-ID", action="store_true", default=False) | ||
| ap.add_argument("--voc-to-coco", action="store_true", default=False) |
| def main(): | ||
| ap = argparse.ArgumentParser(description=__doc__) | ||
|
|
||
| ap.add_argument("--labelbox-json", required=True, type=str, help='path to downloaded labelbox JSON file') |
There was a problem hiding this comment.
can you provide us a small example to test/confirm?
|
|
||
| ap.add_argument("--labelbox-json", required=True, type=str, help='path to downloaded labelbox JSON file') | ||
| ap.add_argument("--save-dir", required=True, type=str) | ||
| ap.add_argument("--keep-original-ID", action="store_true", default=False) |
| ap.add_argument("--save-dir", required=True, type=str) | ||
| ap.add_argument("--keep-original-ID", action="store_true", default=False) | ||
| ap.add_argument("--voc-to-coco", action="store_true", default=False) | ||
| ap.add_argument("--start-index", default=0, type=int) |
There was a problem hiding this comment.
maybe call this resume-index?
| ap.add_argument("--metadata-path", type=Path) | ||
| ap.add_argument("--agcontext-path", type=Path) | ||
| ap.add_argument("--save-image-dir", type=str, help='existing save directory for images') | ||
| ap.add_argument("--save-voc-dir", type=str, help='existing save directory for VOC files') |
There was a problem hiding this comment.
I'm not convinced we need the functionality of saving the VOC. Should be saved to a temp directory, then converted, in the present context of weedcoco?
There was a problem hiding this comment.
It had been a bit of a hack workaround because both were available to me and it was simple to join one to the other, but yes just going straight to weedCOCO would be best maybe with the option to save VOC along the way? Or is that YAGNI
Finished the README and labelbox -> VOC -> weedcoco converter.