test: add unit tests for PropagationTargetsUtils#1
Draft
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Draft
test: add unit tests for PropagationTargetsUtils#1devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: aneesharma1 <[email protected]>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds a new test file
PropagationTargetsUtilsTest.ktwith 14 focused unit tests forPropagationTargetsUtils, which previously had zero test coverage.Tests cover:
falseURIoverload delegation to theString-based method💡 Motivation and Context
PropagationTargetsUtilscontrols whether Sentry trace headers are attached to outgoing HTTP requests — a critical piece of distributed tracing. Despite this, the class had no dedicated unit tests. This PR closes that gap with a small, low-risk, test-only change.💚 How did you test it?
Reviewer checklist
url.matches(origin)branch rather than theurl.contains(origin)branch (they do — the regex literal is not a substring of the test URL).📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Other
sentry/utilclasses with zero test coverage that could benefit from the same treatment:SampleRateUtils(partially covered),ClassLoaderUtils,ErrorUtils,ScopesUtil,UUIDStringUtilsLink to Devin session: https://app.devin.ai/sessions/23aaff7eb99e45c79503152f36003ab8
Requested by: @aks4396