fix(router): use null-prototype objects for parsed URL params#67879
Open
gnesher wants to merge 1 commit intoangular:mainfrom
Open
fix(router): use null-prototype objects for parsed URL params#67879gnesher wants to merge 1 commit intoangular:mainfrom
gnesher wants to merge 1 commit intoangular:mainfrom
Conversation
A query parameter named `hasOwnProperty` overwrites the inherited Object method on the params accumulator, causing a TypeError on the next parameter. Use `Object.create(null)` for both query and matrix param accumulators so no prototype methods can be clobbered, and `Object.prototype.hasOwnProperty.call()` for the duplicate-key check, consistent with the safe pattern already used in `ParamsAsMap` (`shared.ts` line 83). Made-with: Cursor
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A query parameter named
hasOwnPropertyoverwrites the inherited Object method on the params accumulator, causing a TypeError on the next parameter. UseObject.prototype.hasOwnProperty.call()instead, consistent with the safe pattern already used inParamsAsMap(shared.tsline 83).PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Does this PR introduce a breaking change?