docs(material/datepicker): fix incorrect provideLuxonDateAdapter usage for UTC#32975
Open
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Open
docs(material/datepicker): fix incorrect provideLuxonDateAdapter usage for UTC#32975yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Conversation
…e for UTC The docs incorrectly showed provideLuxonDateAdapter accepting a second options parameter for useUtc configuration. Unlike provideMomentDateAdapter, the Luxon adapter provider function only accepts a formats parameter. The correct way to configure UTC parsing is by providing the MAT_LUXON_DATE_ADAPTER_OPTIONS injection token separately. Fixes angular#32935
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Documentation fix
What is the current behavior?
The datepicker overview docs show an incorrect code example for configuring
the Luxon date adapter to parse dates as UTC:
provideLuxonDateAdapteronly accepts one parameter (date formats), not asecond options parameter. This pattern was incorrectly copied from
provideMomentDateAdapterwhich does support a second options parameter.Closes #32935
What is the new behavior?
The docs now show the correct approach using the
MAT_LUXON_DATE_ADAPTER_OPTIONSinjection token:Additional context
Note: PR #32936 proposes adding the options parameter to
provideLuxonDateAdapterto match the Moment adapter API. If that PR ismerged, the docs can be simplified back. This PR fixes the docs to match
the current API.