Skip to content

PowerFlex/ScaleIO storage - the MDMs validation improvements#12893

Open
sureshanaparti wants to merge 1 commit intoapache:4.22from
shapeblue:powerflex_scaleio-mdm-validation-improvements
Open

PowerFlex/ScaleIO storage - the MDMs validation improvements#12893
sureshanaparti wants to merge 1 commit intoapache:4.22from
shapeblue:powerflex_scaleio-mdm-validation-improvements

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Mar 26, 2026

Description

This PR improves the MDMs validations for PowerFlex/ScaleIO storage. Currently only the first MDM IP address is validated, this extends the validation to check all the MDMs of the PowerFlex/ScaleIO storage are present/configured or not and only configures the missing ones.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti added this to the 4.22.1 milestone Mar 26, 2026
@sureshanaparti sureshanaparti moved this from Todo to In Progress in Apache CloudStack 4.22.1 Mar 26, 2026
@codecov
Copy link

codecov bot commented Mar 26, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.60%. Comparing base (d6c3977) to head (2a64ffd).

Files with missing lines Patch % Lines
.../hypervisor/kvm/storage/ScaleIOStorageAdaptor.java 0.00% 19 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #12893      +/-   ##
============================================
- Coverage     17.60%   17.60%   -0.01%     
+ Complexity    15666    15663       -3     
============================================
  Files          5917     5917              
  Lines        531527   531539      +12     
  Branches      64982    64982              
============================================
- Hits          93584    93574      -10     
- Misses       427389   427410      +21     
- Partials      10554    10555       +1
Flag Coverage Δ
uitests 3.70% <ø> (ø)
unittests 18.67% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Mar 26, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 26, 2026

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 26, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17251

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Mar 26, 2026

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Mar 26, 2026

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Mar 27, 2026

[SF] Trillian test result (tid-15746)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50927 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12893-t15746-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

kiranchavala
kiranchavala approved these changes Mar 27, 2026
View reviewed changes
Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

was able to add mdm and query the mdm successfully

[root@ref-trl-11431-k-Mol8-kiran-chavala-kvm1 ~]# /opt/emc/scaleio/sdc/bin/drv_cfg --add_mdm --ip 10.0.32.109 --file /etc/emc/scaleio/drv_cfg.txt
Updating file /etc/emc/scaleio/drv_cfg.txt with MDM (10.0.32.109)
Calling kernel module to connect to MDM (10.0.32.109)
[root@ref-trl-11431-k-Mol8-kiran-chavala-kvm1 ~]# /opt/emc/scaleio/sdc/bin/drv_cfg --query_mdms --file /etc/emc/scaleio/drv_cfg.tx
Retrieved 2 mdm(s)
MDM-ID 456e55753ee96a0f SDC ID 5d48d8fd00000019 INSTALLATION ID 4a6134250af62c2c IPs [0]-10.0.32.170 [1]-10.0.32.108
MDM-ID 0000000000000000 SDC ID 0000000000000000 INSTALLATION ID 0000000000000000 IPs [0]-10.0.32.109

@sureshanaparti sureshanaparti requested a review from nvazquez March 27, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchavala kiranchavala kiranchavala approved these changes

@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

No one assigned

Labels

component:kvm

Projects

Apache CloudStack 4.22.1
Status: In Progress

Milestone

4.22.1

Development

Successfully merging this pull request may close these issues.

3 participants

@sureshanaparti @blueorangutan @kiranchavala