Skip to content

Add allow and deny-insecure server arguments#1281

Closed
nacfe wants to merge 0 commit intoappium:masterfrom
nacfe:master
Closed

Add allow and deny-insecure server arguments#1281
nacfe wants to merge 0 commit intoappium:masterfrom
nacfe:master

Conversation

@nacfe
Copy link
Copy Markdown
Contributor

@nacfe nacfe commented Dec 17, 2019

Change list

  • Add flag "allow-insecure" in GeneralServerFlag.
  • Add flag "deny-insecure" in GeneralServerFlag.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@jsf-clabot
Copy link
Copy Markdown

jsf-clabot commented Dec 17, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nacfe
❌ username12

* Default: []
* Sample: --allow-insecure=foo,bar
*/
ALLOW_INSECURE("--allow-insecure");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also have a constant for --deny-insecure?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I added it now and changed this PR description.

@nacfe nacfe changed the title Adding allow-insecure server argument Add allow and deny-insecure server arguments Dec 17, 2019
@mykola-mokhnach
Copy link
Copy Markdown
Contributor

Could you please sign the CLA?

@nacfe
Copy link
Copy Markdown
Contributor Author

nacfe commented Dec 18, 2019

Could you please sign the CLA?

I already did, but for some reason it says I didn't and doesn't allow me to edit the fields...
When I enter the page it even says "You have signed the CLA for appium/java-client".
I tried with different browsers, same result.

@mykola-mokhnach
Copy link
Copy Markdown
Contributor

You need to make sure the email address of your local git account is the same that has been used to sign the CLA. After the address is fixed try to rebase the PR or create a new one if rebase does not help.

@nacfe
Copy link
Copy Markdown
Contributor Author

nacfe commented Dec 18, 2019

You need to make sure the email address of your local git account is the same that has been used to sign the CLA. After the address is fixed try to rebase the PR or create a new one if rebase does not help.

The email field was already filled with the same email I use on github when I entered the page for the first time. Maybe the fact that I had my email as private and not public made it fail?

@mykola-mokhnach
Copy link
Copy Markdown
Contributor

Does git config --list show this email?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants