Skip to content

[WIP] Setting up the Windows CI#198

Open
rahulbansal16 wants to merge 27 commits intoargotorg:masterfrom
rahulbansal16:rabans/cli/win
Open

[WIP] Setting up the Windows CI#198
rahulbansal16 wants to merge 27 commits intoargotorg:masterfrom
rahulbansal16:rabans/cli/win

Conversation

@rahulbansal16
Copy link
Copy Markdown

What was wrong?

How was it fixed?

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@cburgdorf cburgdorf mentioned this pull request Jan 21, 2021
@cburgdorf
Copy link
Copy Markdown
Collaborator

Regarding the issue with boost maybe this is related to this?

We had to update some paths in solc-rust to get static linking of boost to work.

   println!("cargo:rustc-link-search=native=/usr/lib/");
    println!("cargo:rustc-link-search=native=/usr/lib/x86_64-linux-gnu/");
    println!("cargo:rustc-link-search=native=/usr/local/lib/");

    println!("cargo:rustc-link-lib=static=boost_system");
    println!("cargo:rustc-link-lib=static=boost_filesystem");
    println!("cargo:rustc-link-lib=static=boost_regex")

But as you see these paths are all tailored to Mac and Linux so maybe we have to add paths for Windows here, too? You can create a local fork of solc-rust and then check if any changes here might be working.

@cburgdorf
Copy link
Copy Markdown
Collaborator

Btw, I see all your commits and attempts to get it running, I just want to express how happy I am that you are helping us with that 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants