Fixes issue (uncaught exception) crashing node#878
Open
bugs181 wants to merge 1 commit intobee-queue:masterfrom
Open
Fixes issue (uncaught exception) crashing node#878bugs181 wants to merge 1 commit intobee-queue:masterfrom
bugs181 wants to merge 1 commit intobee-queue:masterfrom
Conversation
Without catching the promise chain HERE, even with proper user-land exception handling, there is no way to properly catch it. This results in an uncaught exception that crashes node. See here for more info: (Uncaught Exception, even with Try Catch)[https://stackoverflow.com/questions/79200499/uncaught-exception-even-with-try-catch]
compwright
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without catching the promise chain HERE, even with proper user-land exception handling, there is no way to catch errors. This results in an uncaught exception that crashes node.
See here for more info: Uncaught Exception, even with Try Catch
Example:
Output:
node:internal/process/promises:391 triggerUncaughtException(err, true /* fromPromise */); ^ Error: connect ECONNREFUSED 127.0.0.1:6090The result is that the entire user application crashes, with no way to recover.