-
Notifications
You must be signed in to change notification settings - Fork 231
Implementes TODO in payments-service.ts. convert user admission to postgres stored function #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cameri
merged 4 commits into
cameri:main
from
Mohit-Davar:refactor/admit-user-stored-func
Apr 18, 2026
+53
−8
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0861163
refactor: convert user admission to postgres stored function
Mohit-Davar bdd781a
Merge branch 'main' into refactor/admit-user-stored-func
cameri add0320
Merge branch 'main' into refactor/admit-user-stored-func
cameri 293e1b5
Merge branch 'main' into refactor/admit-user-stored-func
cameri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| exports.up = async function (knex) { | ||
| return knex.schema | ||
| .raw( | ||
| `CREATE OR REPLACE FUNCTION admit_user(user_pubkey BYTEA, tos_accepted TIMESTAMP WITHOUT TIME ZONE) | ||
| RETURNS INTEGER | ||
| LANGUAGE plpgsql | ||
| AS $$ | ||
| BEGIN | ||
| PERFORM ASSERT_SERIALIZED(); | ||
|
|
||
| INSERT INTO "users" ("pubkey", "is_admitted", "tos_accepted_at", "created_at", "updated_at") | ||
| VALUES (user_pubkey, true, tos_accepted, now_utc(), now_utc()) | ||
| ON CONFLICT ("pubkey") | ||
| DO UPDATE SET | ||
| "is_admitted" = true, | ||
| "tos_accepted_at" = tos_accepted, | ||
| "updated_at" = now_utc(); | ||
|
|
||
| RETURN 0; | ||
| END; | ||
| $$;`) | ||
| } | ||
|
|
||
| exports.down = function (knex) { | ||
| return knex.schema | ||
| .raw('DROP FUNCTION IF EXISTS admit_user(BYTEA, TIMESTAMP WITHOUT TIME ZONE);') | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.