fix(scaletest/prebuilds): fix Runner.Cleanup() to delete workspaces#23627
Open
fix(scaletest/prebuilds): fix Runner.Cleanup() to delete workspaces#23627
Conversation
…efore template The API rejects template deletion with a 400 while workspaces still exist. Cleanup() now lists all workspaces for the template, deletes each via workspacebuild.NewCleanupRunner with up to 3 retries, then deletes the template. If Run() fails with a 409 conflict (template already exists from a prior failed run), the existing template is looked up so Cleanup() can remove it rather than silently skipping it.
… deletion retries Log every deletion attempt (not just retries) and return an error if workspaces remain after all attempts, rather than logging an error and proceeding to template deletion which would fail anyway. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
I have read the CLA Document and I hereby sign the CLA Callum Styan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
Cleanupfunction for prebuild scaletests more reliable. Currently,Cleanupjust attempts to delete the prebuilds templates, but templates cannot be deleted if there are any workspaces created from them remaining.This is problematic because we don't currently generate unique template names on each new prebuilds scaletest run, so this leaves the cluster in a state where another prebuild scaletest cannot be executed without some manual cleanup first.
So, in this PR we're modifying
Cleanupto first check for workspaces for the given runners template. It then attempts to delete those workspaces, retrying up to 3x, before finally moving on to the template deletion.This also means we're properly deleting workspaces for a template if we fail during a call to
Run.