fix(site/src/pages/AgentsPage): fire chat-ready after store sync so scroll-to-bottom hits rendered DOM#23693
Open
fix(site/src/pages/AgentsPage): fire chat-ready after store sync so scroll-to-bottom hits rendered DOM#23693
Conversation
69c4242 to
e6a8166
Compare
e6a8166 to
e163979
Compare
EhabY
commented
Mar 27, 2026
| applyEmbedTheme(theme); | ||
| return; | ||
| } | ||
| if (event.data?.type === "coder:scroll-to-bottom") { |
Contributor
Author
There was a problem hiding this comment.
Removed this whole thing since now the embed scrolls to the bottom on load anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onChatReadynow waits for the store to have all fetched messages (not just query success), so the DOM has content when the parent frame acts on the signal. Removed thescroll-to-bottomround-trip fromonChatReady, the embed page no longer needs the parent to echo a scroll command back.Also moved
autoScrollRefcheck before thewidthChangedguard inScrollAnchoredContainer's ResizeObserver. The width guard is only relevant for scroll compensation (user scrolled up); it should never prevent pinning to bottom when auto-scroll is active. Also tightened the store sync guard tostoreMessageCount < fetchedMessageCount.