Skip to content

Drop numpy as a dependency#65

Merged
mcflugen merged 1 commit intocsdms:masterfrom
mcflugen:mcflugen/drop-numpy-dependency
Mar 29, 2026
Merged

Drop numpy as a dependency#65
mcflugen merged 1 commit intocsdms:masterfrom
mcflugen:mcflugen/drop-numpy-dependency

Conversation

@mcflugen
Copy link
Copy Markdown
Member

@mcflugen mcflugen commented Mar 28, 2026

Since we only use numpy for type checking, there's no need to have it as a dependency, so I've dropped it.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 28, 2026

Coverage Status

coverage: 77.826% (-0.7%) from 78.509%
when pulling 2ce15a0 on mcflugen:mcflugen/drop-numpy-dependency
into 2434b8d on csdms:master.

@mcflugen mcflugen force-pushed the mcflugen/drop-numpy-dependency branch from d972197 to e74b356 Compare March 28, 2026 23:32
@mcflugen mcflugen requested a review from mdpiper March 28, 2026 23:39
This was referenced Mar 29, 2026
@mcflugen mcflugen force-pushed the mcflugen/drop-numpy-dependency branch from e74b356 to 2ce15a0 Compare March 29, 2026 06:15
@mcflugen mcflugen force-pushed the mcflugen/drop-numpy-dependency branch from 2ce15a0 to 6ca83aa Compare March 29, 2026 20:58
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.25%. Comparing base (162c445) to head (d7948dd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   96.26%   96.25%   -0.02%     
==========================================
  Files           8        8              
  Lines         268      267       -1     
  Branches       11       11              
==========================================
- Hits          258      257       -1     
  Misses          8        8              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcflugen mcflugen force-pushed the mcflugen/drop-numpy-dependency branch 3 times, most recently from 02ebdb2 to 5dfcf00 Compare March 29, 2026 22:50
* wrap numpy imports in TYPE_CHECKING
* remove numpy from runtime dependencies
* add numpy as a testing requirement
* update CI/nox configuration
@mcflugen mcflugen force-pushed the mcflugen/drop-numpy-dependency branch from 5dfcf00 to d7948dd Compare March 29, 2026 22:51
@mcflugen mcflugen merged commit 633e72c into csdms:master Mar 29, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants