DAOS-18086 control: Fix data race in drpc unit test#17979
Merged
daltonbohning merged 1 commit intomasterfrom Apr 14, 2026
Merged
DAOS-18086 control: Fix data race in drpc unit test#17979daltonbohning merged 1 commit intomasterfrom
daltonbohning merged 1 commit intomasterfrom
Conversation
This issue was only affecting unit tests. Signed-off-by: Kris Jacque <[email protected]>
Contributor
Author
|
Scripted "go test -race" runs for this test 100 times in a row. I was able to reproduce the original issue within 100 runs on master, but not with this patch. |
mjmac
approved these changes
Apr 10, 2026
|
Ticket title is 'Unit Tests / Unit Test on EL 8.8 / UTEST_control.drpc.TestServer_Listen_AcceptConnection: data race' |
tanabarr
approved these changes
Apr 13, 2026
Contributor
Author
|
Functional hardware tests didn't run due to an existing issue in CI. However: this is a Go unit test only fix. |
daltonbohning
pushed a commit
that referenced
this pull request
Apr 23, 2026
This issue was only affecting unit tests. Signed-off-by: Kris Jacque <[email protected]>
mchaarawi
pushed a commit
that referenced
this pull request
Apr 27, 2026
The mock for this test wasn't updated when we switched to dRPC message chunking, so the mocked sessions were failing and being removed. Whether they were removed early enough for the test to detect was intermittent. - Populate valid data in the mockConn used for each mock session. This ensures the sessions remain "open" until the context is canceled (i.e. the test ends). - Add a brief sleep in the test to allow for the goroutines to either die or remain stable. This allowed the test to reproduce the bug 100% of the time. - Update to a table-based test format for the affected tests. Signed-off-by: Kris Jacque <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was only affecting unit tests.
Steps for the author:
After all prior steps are complete: