Convert to SDK style project and update dependencies#22
Open
ericstj wants to merge 1 commit intodevtrends:masterfrom
Open
Convert to SDK style project and update dependencies#22ericstj wants to merge 1 commit intodevtrends:masterfrom
ericstj wants to merge 1 commit intodevtrends:masterfrom
Conversation
Author
|
@devtrends would it be possible to consider this - or a smaller version of it if you prefer? Updating the dependency on Microsoft.AspNet.WebApi.Core will help folks avoid CVE alerts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I commented in #21 about how just updating newtonsoft wasn't the correct thing, so I thought I'd give a try at updating this project myself.
I converted to SDK style and retained the same package structure (probably it could be modernized to use ContentFiles, but I'm not super familiar with that).
I also made it do public signing - which is "fake signing" with just an exported public key. If you were to accept this change and you have the real keypair, you'd want to make sure you build and override the two properties
/p:AssemblyOriginatorKeyFile=<pathToRealSNK> /p:PublicSign=false