Allow user to add groups to a container#950
Conversation
Suggested here docker-java#948
This reverts commit fa04aed
Codecov Report
@@ Coverage Diff @@
## master #950 +/- ##
==========================================
+ Coverage 59.34% 61.92% +2.58%
==========================================
Files 441 411 -30
Lines 8699 8189 -510
Branches 540 530 -10
==========================================
- Hits 5162 5071 -91
+ Misses 3238 2817 -421
- Partials 299 301 +2
Continue to review full report at Codecov.
|
|
|
||
| @Override | ||
| public CreateContainerCmd withGroupAdd(String[] groupAdd) { | ||
| checkNotNull(groupAdd, "groupAdd was not specified"); |
| * @see #groupAdd | ||
| */ | ||
| @CheckForNull | ||
| public String[] getGroupAdd() { |
Removing null check and switched array to a String List.
|
Updated this PR with changes from master. Build is currently broken because eclipse.org is sending a 302 with a reference to their error page on a missing dependency instead of a proper 404. Should build cleanly again when their repo repo is back in a sane state. |
|
|
||
| @Override | ||
| @JsonIgnore | ||
| public List<String> getGroupAdd() { |
There was a problem hiding this comment.
don't proxy host changes, keep only getter/setters in hostconfig
There was a problem hiding this comment.
Would that not make it awkward to use?
I saw several parts of hostconfig being proxied, is there a practice for which of them to expose?
Adds support for the --add-group parameter for container creation and inspection.
Solves #907
This change is