Skip to content

fix: Upgrade setuptools to 70.1.0+ to support wheel v0.46.0 compatibility#1022

Closed
geminixiang wants to merge 4 commits intodocker-library:masterfrom
geminixiang:master
Closed

fix: Upgrade setuptools to 70.1.0+ to support wheel v0.46.0 compatibility#1022
geminixiang wants to merge 4 commits intodocker-library:masterfrom
geminixiang:master

Conversation

@geminixiang
Copy link
Copy Markdown

@geminixiang geminixiang commented Apr 9, 2025

Fixes #1021

wheel: pypa/wheel#662, pypa/wheel#660

Problem

After wheel v0.46.0 was released, bdist_wheel command migrate to setupstools>=70.1.0, link, it became incompatible with setuptools versions below 70.1.0.

UPDATE: wheel yank v0.46.0 https://pypi.org/project/wheel/#history
discussion: pypa/wheel#662 (comment)

Solution

This PR upgrades setuptools to version 70.1.0 or higher in all Docker containers to ensure compatibility with wheel v0.46.0+.

@geminixiang geminixiang marked this pull request as ready for review April 9, 2025 12:24
@agronholm
Copy link
Copy Markdown

Is there a reason why you picked this specific setuptools version? I would probably have used v70.3.0 instead, as it's the most up to date version that doesn't introduce potential compatibility issues.

@geminixiang
Copy link
Copy Markdown
Author

geminixiang commented Apr 9, 2025

Is there a reason why you picked this specific setuptools version? I would probably have used v70.3.0 instead, as it's the most up to date version that doesn't introduce potential compatibility issues.

I reviewed the following file and confirmed that v70.1.0 was when bdist_wheel was first added to setuptools:

https://github.com/pypa/setuptools/blob/3a3144f0d2887fa37c06550f42a101e9eebd953a/NEWS.rst?plain=1#L627-L633

but now... the version you mentioned, v70.3.0, seems better.

@yosifkit
Copy link
Copy Markdown
Member

yosifkit commented Apr 9, 2025

#1023 (comment)

I agree with edmorely and so we'll be taking the least breaking approach by just pinning the wheel version.

@yosifkit yosifkit closed this Apr 9, 2025
@y-tee
Copy link
Copy Markdown

y-tee commented Apr 11, 2025

Hi is there any plans to upgrade the setuptools to >70.0 since there is a cve on the setuptools version before this: https://www.cve.org/CVERecord?id=CVE-2024-6345

the cve allows remote code execution

@yosifkit
Copy link
Copy Markdown
Member

is there any plans to upgrade the setuptools to >70.0

No. Related issue: #1012 and long explanation: #781 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

alpine3.20 introduce 'bdist_wheel' error when using pip

4 participants