Open
Conversation
Shims in octave_compat/ replace MATLAB-only features: - graph/conncomp/shortestpath/minspantree (BFS, Dijkstra, Prim) - quadprog wrapper handling Octave's stricter rank requirements - wrapToPi, readOBJ (fast bulk parser) run_octave_validation.m runs all 3 benchmark meshes (pig, B36, SquareMyles) with their reference configs and saves numerical outputs. Individual test scripts (test_octave_*.m) allow running each mesh separately for debugging. All meshes produce 0 flipped triangles and converge successfully under GNU Octave 10.3.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds shims and scripts so the full pipeline runs under GNU Octave (tested with 10.3.0), no MATLAB license required.
octave_compat/— drop-in replacements for MATLAB-only functions:graph,conncomp,shortestpath,minspantree(BFS, Dijkstra, Prim implementations)quadprogwrapper handling Octave's stricter rank requirementswrapToPi,readOBJ(fast bulk OBJ parser)Validation scripts:
run_octave_validation.m— runs all 3 benchmark meshes (pig, B36, SquareMyles) with reference configstest_octave_*.m— individual test scripts for each meshAll three benchmark meshes produce 0 flipped triangles and converge successfully.
Note
While porting this codebase to Python (validating against Octave), I noticed a few edge cases where
ismembercan return 0 (not found) and the result is used for array indexing — this would error on certain mesh topologies where not all expected elements are found intri_fix_cut. The three benchmark meshes aren't affected. Happy to provide details or a separate PR if useful.