Add ImageEditAs type and update addImage method to support 'twoCell' option#2983
Open
hshoja wants to merge 1 commit intoexceljs:masterfrom
Open
Add ImageEditAs type and update addImage method to support 'twoCell' option#2983hshoja wants to merge 1 commit intoexceljs:masterfrom
hshoja wants to merge 1 commit intoexceljs:masterfrom
Conversation
|
@hshoja is this suppose to keep the aspect ratio also? |
Author
By default, the "lock aspect ratio" settings are applied in all cases within Excel.
I introduced The editAs property in the library is defined as follows: You might want to try using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR adds support for the
twoCelleditAsoption when adding images to Excel worksheets. This feature allows images to be moved and sized with cells, providing better integration with Excel's filtering and row manipulation features.This addresses the issue discussed in GitHub Discussion #2648 where the images remain visible when rows containing them are filtered or removed. The current library only supports
oneCell(default) andabsolutepositioning, but Excel's nativetwoCelloption provides the expected behavior for images that should move and resize with their containing cells.twoCellfunctionalityTest plan
See working example demonstrating the
twoCellfunctionality: ExcelJS twoCell Example