feat: add getFirstWorksheet() method to safely get first existing worksheet #2991
Open
freepad wants to merge 3 commits intoexceljs:masterfrom
Open
feat: add getFirstWorksheet() method to safely get first existing worksheet #2991freepad wants to merge 3 commits intoexceljs:masterfrom
freepad wants to merge 3 commits intoexceljs:masterfrom
Conversation
…ksheet This method finds and returns the first worksheet that exists (not deleted), regardless of its id. Resolves the issue where getWorksheet(1) would fail after deleting the first worksheet.
…ksheet This method finds and returns the first worksheet that visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This method finds and returns the first worksheet that exists (not deleted), regardless of its id. Resolves the issue where getWorksheet(1) would fail after deleting the first worksheet.
Problem: When users delete worksheets, the IDs don't get reassigned. So after deleting worksheet with id=1, calling getWorksheet(1) returns undefined even though other worksheets exist.
Solution: The new getFirstWorksheet() method finds the first existing worksheet in the internal array, providing a reliable way to get the first worksheet regardless of deletions.
Test plan
I wrote unit-tests covering all scenarios:
Run with:
All tests pass (5/5).