test: Add unit tests for online stores, compute engines, and transformations#6149
Open
Srihari1192 wants to merge 1 commit intofeast-dev:masterfrom
Open
test: Add unit tests for online stores, compute engines, and transformations#6149Srihari1192 wants to merge 1 commit intofeast-dev:masterfrom
Srihari1192 wants to merge 1 commit intofeast-dev:masterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
|
@ntkathole Please review |
ntkathole
reviewed
Mar 26, 2026
| from feast.infra.online_stores.vector_store import VectorStoreConfig | ||
|
|
||
|
|
||
| class TestVectorStoreConfig: |
Member
There was a problem hiding this comment.
these tests has no value - VectorStoreConfig is a plain Python class, tests just set an attribute and read it back
ntkathole
reviewed
Mar 26, 2026
sdk/python/tests/unit/transformation/test_sql_transformation.py
Outdated
Show resolved
Hide resolved
ntkathole
reviewed
Mar 26, 2026
ntkathole
reviewed
Mar 26, 2026
sdk/python/tests/unit/infra/compute_engines/test_materialization_job.py
Outdated
Show resolved
Hide resolved
…mpute engines, and transformations
Add 9 new test files with 74 unit tests covering previously untested
modules to improve the test-to-source ratio.
Bug fix:
- Fix BackendFactory.infer_from_entity_df where `not entity_df` crashes
for pandas DataFrames with ValueError("The truth value of a DataFrame
is ambiguous"). Reorder conditions to check isinstance first, making
the isinstance(entity_df, pd.DataFrame) check reachable.
Coverage added:
- Online Stores (2 files, 23 tests): helpers, base class
- Compute Engines (5 files, 37 tests): topological sort, backend factory,
local engine/jobs, materialization
- Transformations (3 files, 14 tests): factory resolution, SQL transformation,
mode enum
All tests are pure unit tests with no infrastructure dependencies.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: Ambient Code Bot <[email protected]>
ac7a35e to
2173740
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add 11 new test files with 81 unit tests covering previously untested modules to improve the test-to-source ratio for AI Bug Automation Readiness. All tests are pure unit tests with no infrastructure dependencies.
Which issue(s) this PR fixes:
Checks
git commit -s)Testing Strategy
Test Coverage Added
Misc