Skip to content

fix: Ignore ipynb files during apply#6151

Merged
ntkathole merged 6 commits intofeast-dev:masterfrom
saipuneet357:bugfix/ignore_ipynb_apply_cli
Mar 27, 2026
Merged

fix: Ignore ipynb files during apply#6151
ntkathole merged 6 commits intofeast-dev:masterfrom
saipuneet357:bugfix/ignore_ipynb_apply_cli

Conversation

@saipuneet357
Copy link
Contributor

@saipuneet357 saipuneet357 commented Mar 25, 2026 •
edited by devin-ai-integration bot
Loading

What this PR does / why we need it:

Ignore Jupyter Notebook Files when we run feast apply

Which issue(s) this PR fixes:

Fixes #5145

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc

5 of the integration tests are failing due to creating a new spark environment for testing in the functions:

  1. sdk/python/tests/component/spark/test_spark_materialization_engine.py
  2. sdk/python/tests/component/spark/test_compute.py
  3. sdk/python/tests/component/spark/test_compute_dag.py

Now these tests are failing even without the change though. I'll take a look if something is wrong with the test or my environment.

Open with Devin

@saipuneet357 saipuneet357 requested a review from a team as a code owner March 25, 2026 10:45
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@saipuneet357 saipuneet357 mentioned this pull request Mar 25, 2026
Closed
@saipuneet357 saipuneet357 force-pushed the bugfix/ignore_ipynb_apply_cli branch 3 times, most recently from ffe3242 to fa8ba56 Compare March 25, 2026 16:55
@ntkathole
Copy link
Member

ntkathole commented Mar 26, 2026

@saipuneet357 if you see discussion on #5177 (comment)

The problem is actually with ipynb_checkpoints created in nestead directories as well. When we work inside a JupyterLab workbench and edit .py files (like your Feast feature definitions) in any subdirectory, Jupyter creates .ipynb_checkpoints/ in that subdirectory with checkpoint copies of your .py files. Those checkpoint .py files contain the same Feast object definitions, so feast apply finds and that cause issues.

Fix also needs:

"**/.pytest_cache",
"**/__pycache__",
"**/.ipynb_checkpoints",

@saipuneet357 saipuneet357 force-pushed the bugfix/ignore_ipynb_apply_cli branch from fa8ba56 to 5e20ccb Compare March 26, 2026 18:11
@saipuneet357
Copy link
Contributor Author

saipuneet357 commented Mar 26, 2026

@ntkathole Thanks for the clarification, it really helped me out!

I added

"**/*.ipynb_checkpoints",
"**/*.pytest_cache",
"**/*__pycache__",

to the ignore paths, and tested it out after editing a feast definition on jupyterlab in a subdirectory, and it no longer fails.

I guess we can also remove
"**/*.ipynb",
as its redundant

@saipuneet357 saipuneet357 force-pushed the bugfix/ignore_ipynb_apply_cli branch from f7db7e7 to ebf7ef8 Compare March 26, 2026 18:45
@saipuneet357
Pre commit Hook changes
119551b 
Signed-off-by: Saipuneet Munikuntla <[email protected]>
@saipuneet357
Filtering out pytest_cache, __pycache__, and ipynb_checkpoints in all…
995e2db 
… subdirectories during feast apply

Signed-off-by: Saipuneet Munikuntla <[email protected]>
@saipuneet357
removing **/*.ipynb as its redundant
6bd2a25 
Signed-off-by: Saipuneet Munikuntla <[email protected]>
@saipuneet357
Removing broad glob pattern and only keeping exact match of directory…
452ed86 
… name inside subdirectories

Signed-off-by: Saipuneet Munikuntla <[email protected]>
@saipuneet357
Adding tests to validated if checkpoints are being picked up in subdi…
7064d1e 
…rectories

Signed-off-by: Saipuneet Munikuntla <[email protected]>
@saipuneet357 saipuneet357 force-pushed the bugfix/ignore_ipynb_apply_cli branch from ebf7ef8 to 7064d1e Compare March 26, 2026 18:46
@ntkathole ntkathole changed the title fix: ignore ipynb files during apply fix: Ignore ipynb files during apply Mar 27, 2026
@ntkathole
Copy link
Member

ntkathole commented Mar 27, 2026

@saipuneet357 please fix the tests

@saipuneet357
Fixing Tests To Incorporate New Changes
4b20be8 
Signed-off-by: Saipuneet Munikuntla <[email protected]>
@ntkathole ntkathole merged commit 4ea123d into feast-dev:master Mar 27, 2026
31 of 32 checks passed
@ntkathole ntkathole mentioned this pull request Mar 27, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feast apply should ignore Jupyter Notebooks

3 participants

@saipuneet357 @ntkathole @franciscojavierarceo