Skip to content

Homework Week1 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuanprae wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Homework Week1 #26

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
02c6a13
Add array, object containing book info and function listItems
nuanprae Feb 15, 2021
9387ad0
Remove bookTitles array and use Object.keys in listItems function
nuanprae Feb 16, 2021
735092a
Add img folder and display book covers
nuanprae Feb 16, 2021
61d5e1d
Change to follow instructions
nuanprae Feb 16, 2021
fd66828
Add info and image by checking id
nuanprae Feb 17, 2021
49064c3
Refactor functions to follow instructions
nuanprae Feb 17, 2021
ca88fda
Style page using grid
nuanprae Feb 17, 2021
ca82d97
Add minmax auto-fit
nuanprae Feb 17, 2021
ed5aa41
Change bookCovers to images
nuanprae Feb 17, 2021
68f9d14
Change background colour
nuanprae Feb 17, 2021
dbfc4c4
Refactor placeImage() to be part of generateItems()
nuanprae Feb 19, 2021
453613d
Remove 2nd for loop
nuanprae Feb 19, 2021
38f6ef7
Refactor so image can be moved within li and always corresponds to sa…
nuanprae Feb 19, 2021
791b986
Comment out unused array and function
nuanprae Feb 19, 2021
ba1e81c
Use bookTitles array to display items and create a function to inject…
nuanprae Feb 19, 2021
cd254ea
Add semantic html
nuanprae Feb 19, 2021
8cbfd89
Refactor to get keys from books object
nuanprae Feb 22, 2021
06bedc6
Insert image after title of book
nuanprae Feb 22, 2021
a1bbfde
Pull from remote and fix conflict
nuanprae Feb 23, 2021
cfac9ce
Remove extra ul in style.css
nuanprae Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor so image can be moved within li and always corresponds to sa… 
…me info
  • Loading branch information
@nuanprae
nuanprae committed Feb 19, 2021
commit 38f6ef79e9c4dec5fb2abe38b7fdf9b5fcad9260
6 changes: 1 addition & 5 deletions Week1/homework/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
const generateItems = (info, images) => {
const ul = document.createElement('ul');
document.body.appendChild(ul);
// loop over bookObj and append each li (with info) to ul
// loop over bookObj and append each li to ul (book info and book cover)
for (const key of Object.keys(info)) {
const li = document.createElement('li');
ul.appendChild(li);
Expand All @@ -123,10 +123,6 @@
li.appendChild(subHeading2);
subHeading2.innerHTML = `Author: ${info[key].author}`;
}
// loop over bookCovers object and display the corresponding book cover for each li
// for (const key of Object.keys(images)) {

// }
};

// generate page
Expand Down