add the 'fitBounds()' functionality#12
Closed
sandrotosi wants to merge 1 commit intogmplot:masterfrom
sandrotosi:fitBounds
Closed
add the 'fitBounds()' functionality#12sandrotosi wants to merge 1 commit intogmplot:masterfrom sandrotosi:fitBounds
sandrotosi wants to merge 1 commit intogmplot:masterfrom
sandrotosi:fitBounds
Conversation
This function takes 2 sets of arguments, the North-East Lat/Lng and the South-West Lat/Lng, which are used to compute a LatLngBounds() which is then passed to the gmap fitBounds() method. The result is a map with the correct zoom to show the NE-SW region. As a possible improvement, we could automatically store the NE/SW corners for every new object added to the map (via gmplot methods) and then just 'requesting' to fit those bounds by flipping a True/False flag.
Contributor
Author
|
@vgm64 ping |
823e3ad to
ad6df42
Compare
Contributor
Author
|
updated at #125 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function takes 2 sets of arguments, the North-East Lat/Lng and the
South-West Lat/Lng, which are used to compute a LatLngBounds() which is then
passed to the gmap fitBounds() method.
The result is a map with the correct zoom to show the NE-SW region.
As a possible improvement, we could automatically store the NE/SW corners for
every new object added to the map (via gmplot methods) and then just
'requesting' to fit those bounds by flipping a True/False flag.