Skip to content

feat(P9-F001): add technical details section to wiki articles#22

Merged
hangtime79 merged 1 commit intomasterfrom
feature/p9-f001
Dec 1, 2025
Merged

feat(P9-F001): add technical details section to wiki articles#22
hangtime79 merged 1 commit intomasterfrom
feature/p9-f001

Conversation

@hangtime79
Copy link
Copy Markdown
Owner

Summary

Implements Phase 9, Feature P9-F001: Generate Technical Details Section for CatalogWriter wiki articles.

Changes

  • Add _generate_technical_details() method to CatalogWriter

    • Creates collapsible sections for each dataset schema
    • Displays column samples in markdown tables
    • Links to full schema JSON files in Library
  • Integrate method call in generate_wiki_article()

    • Placed after Flow Diagram section
    • Only for EnhancedBlockMetadata instances
  • Update navigation menu

    • Remove "(Coming soon)" from Technical Details link
  • Add comprehensive test suite

    • New file: test_catalog_writer_tech.py
    • 6 test cases covering all edge cases
  • Update existing tests

    • Fix 2 tests expecting "Coming soon" text

Test Results

  • New tests: 6/6 passing (100%)
  • All catalog_writer tests: 57/57 passing (100%)
  • Pre-commit hooks: black ✓, ruff ✓
  • No regressions introduced

Acceptance Criteria

  • ✅ Generates technical details section with dataset schemas
  • ✅ Includes schema tables in collapsible details
  • ✅ Includes links to schema JSON files
  • ✅ All unit tests pass
  • ✅ No regressions in existing tests
  • ✅ Follows existing code patterns and conventions

🤖 Generated with Claude Code

Implements Phase 9, Feature P9-F001: Generate Technical Details Section

Changes:
- Add _generate_technical_details() method to CatalogWriter
  * Creates collapsible sections for each dataset schema
  * Displays column samples in markdown tables
  * Links to full schema JSON files in Library
  * Returns empty string when no datasets present

- Integrate method call in generate_wiki_article()
  * Placed after Flow Diagram section
  * Only for EnhancedBlockMetadata instances

- Update navigation menu
  * Remove "_(Coming soon)_" from Technical Details link

- Add comprehensive test suite
  * New file: test_catalog_writer_tech.py
  * 6 test cases covering all edge cases
  * 100% pass rate (57/57 tests across all catalog_writer tests)

- Update existing tests
  * Fix 2 tests expecting "Coming soon" text
  * All regression tests pass

Technical Details:
- Uses .get("sample", []) for safe dict access
- Column type shows "-" placeholder (per spec)
- Schema file path matches existing _write_schemas() pattern
- Follows existing code patterns and conventions

Test Results:
- New tests: 6/6 passing (100%)
- All catalog_writer tests: 57/57 passing (100%)
- No regressions introduced

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@hangtime79 hangtime79 merged commit 65fe055 into master Dec 1, 2025
4 checks passed
@hangtime79 hangtime79 deleted the feature/p9-f001 branch December 1, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant