Skip to content

Intensities threshold#135

Open
ericpre wants to merge 2 commits intohyperspy:mainfrom
ericpre:intensities_threshold
Open

Intensities threshold#135
ericpre wants to merge 2 commits intohyperspy:mainfrom
ericpre:intensities_threshold

Conversation

@ericpre
Copy link
Copy Markdown
Member

@ericpre ericpre commented Jul 27, 2025

Add threshold to set intensities to zero during and/or after quantification. This is useful to set quantification results to zero when there is very small intensities.

Progress of the PR

  • Add intensities_threshold to set intensities values to 0 when it is below the threshold,
  • add intensities_sum_threshold to set quantified values to set when it is below the threshold,
  • docstring updated (if appropriate),
  • update user guide (if appropriate),
  • added tests,
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:exspy build of this PR (link in github checks)
  • ready for review.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 27, 2025

Codecov Report

❌ Patch coverage is 93.22034% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.88%. Comparing base (2ba5219) to head (b607731).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
exspy/_misc/eds/utils.py 88.23% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   88.86%   88.88%   +0.02%     
==========================================
  Files          79       79              
  Lines        7650     7693      +43     
  Branches      910      916       +6     
==========================================
+ Hits         6798     6838      +40     
  Misses        578      578              
- Partials      274      277       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericpre ericpre force-pushed the intensities_threshold branch from 9ad24c4 to b607731 Compare January 19, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant