Skip to content

Add functionality to find EDS lines interactively#162

Open
ericpre wants to merge 5 commits intohyperspy:mainfrom
ericpre:add_gui_lines_at_energy
Open

Add functionality to find EDS lines interactively#162
ericpre wants to merge 5 commits intohyperspy:mainfrom
ericpre:add_gui_lines_at_energy

Conversation

@ericpre
Copy link
Copy Markdown
Member

@ericpre ericpre commented Jan 24, 2026 •
edited
Loading

It needs hyperspy/hyperspy#3564 and hyperspy/hyperspy_gui_ipywidgets#95.

Progress of the PR

  • Add functionality to find EDS lines interactively,
  • docstring updated (if appropriate),
  • update user guide (if appropriate),
  • added tests,
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:exspy build of this PR (link in github checks)
  • ready for review.

Example

import exspy

s = exspy.data.EDS_TEM_FePt_nanoparticles()
s.lines_at_energy(toolkit="ipywidgets")
image

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (bf7118f) to head (b31f47c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   88.33%   88.52%   +0.19%     
==========================================
  Files         100      101       +1     
  Lines        7764     7867     +103     
  Branches      932      941       +9     
==========================================
+ Hits         6858     6964     +106     
+ Misses        632      629       -3     
  Partials      274      274

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericpre ericpre mentioned this pull request Jan 24, 2026
Closed
@jlaehne jlaehne added this to the v0.3.3 milestone Jan 25, 2026
@ericpre ericpre mentioned this pull request Jan 25, 2026
Merged
5 tasks
@ericpre ericpre force-pushed the add_gui_lines_at_energy branch 5 times, most recently from f157630 to 00d0297 Compare February 22, 2026 15:59
@ericpre ericpre force-pushed the add_gui_lines_at_energy branch from 00d0297 to ca8a958 Compare April 11, 2026 08:39
@ericpre ericpre force-pushed the add_gui_lines_at_energy branch from ca8a958 to b31f47c Compare April 11, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: needs review type: new feature

Projects

None yet

Milestone

v0.3.3

Development

Successfully merging this pull request may close these issues.

2 participants

@ericpre @jlaehne