Skip to content

Topic/ceph#7

Open
sslipchenko wants to merge 3 commits intohypertable:topic/cephfrom
sslipchenko:topic/ceph
Open

Topic/ceph#7
sslipchenko wants to merge 3 commits intohypertable:topic/cephfrom
sslipchenko:topic/ceph

Conversation

@sslipchenko
Copy link
Copy Markdown

Hi,

Please review my fixes for "topic/ceph" branch.

I've found that you updated Ceph broker sources to support new libcephfs, but I suppose you didn't test it yet. There are several bugs.

  • CephBroker.Id and CephBroker.RootDir properties aren't declared in Hypertable config and thus CephBroker doesn't start.
  • You are calling ceph_read and ceph_write with offset 0 that means read/write at position 0, but not read/wrire at current position, which is expected for CephBroker::append and CephBroker::read.

@sslipchenko
Copy link
Copy Markdown
Author

I sent Hypertable Contributor Agreement to [email protected]

@nuggetwheat
Copy link
Copy Markdown

Hi Serge,

Thanks! I'll go ahead and merge the changes today. If I have any
questions, I'll let you know.

  • Doug

On Wed, Aug 28, 2013 at 3:13 AM, Serge Slipchenko
[email protected]:

I sent Hypertable Contributor Agreement to [email protected]


Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-23403908
.

Doug Judd
CEO, Hypertable Inc.

@GregBowyer
Copy link
Copy Markdown

Did this get merged ?

@nuggetwheat
Copy link
Copy Markdown

Hi Greg, I have not pulled it yet. It turned out to be more challenging that I had expected. Ceph requires newer versions of the operating systems which are incompatible with our build systems. We still need to figure out how to integrate it into our release process.

@nuggetwheat nuggetwheat reopened this Jan 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants