feat: add FormData support to rawRequest for multipart uploads#429
Open
GFlores17 wants to merge 1 commit intolionralfs:mainfrom
Open
feat: add FormData support to rawRequest for multipart uploads#429GFlores17 wants to merge 1 commit intolionralfs:mainfrom
GFlores17 wants to merge 1 commit intolionralfs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
rawRequestinclient.tsto supportmultipart/form-datarequests alongside the existing
application/jsonbehavior.Changes
RequestOptionstype intypes.tsto acceptFormDatain addition to
Record<string, unknown>rawRequestinclient.tsto check ifdatais aFormDatainstance and skip JSON stringification and manualContent-Typeheader in that case, allowingfetchto set thecorrect
multipart/form-dataheader automaticallyMotivation
Required groundwork for implementing the inventory upload endpoints
(related to #78). The Discogs inventory upload API expects
multipart/form-datawith a CSV file, which the currentimplementation doesn't support.
Testing
All existing tests pass — no current behavior is affected.