Add thumbnail for embedding_in_tk example#31365
Add thumbnail for embedding_in_tk example#31365buddy0452004 wants to merge 4 commits intomatplotlib:mainfrom
Conversation
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on gitter for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
|
While these images are displaying what the Matplotlib side of the examples produce, I don't think these are good indicators of what the examples are. The point of the embedding examples is that they are in Tk (or Qt or whatever); if we wanted just the Matplotlib part, these would be regular examples without any of that extra stuff. |
|
Thanks for the feedback @QuLogic! You're right the screenshots should show the full GUI window including the Tk/Qt frame and controls, not just the Matplotlib plot. I will retake the screenshots to show the complete embedding context. |
|
@QuLogic Retook all screenshots to show the full GUI window including title bar, toolbar, slider and controls. Should now properly represent what each embedding example does. |
Adds thumbnails for multiple sgskip examples in the user_interfaces gallery that were missing preview images.
Examples covered:
embedding_in_tk_sgskip.py(Tkinter)embedding_in_qt_sgskip.py(PyQt5)embedding_webagg_sgskip.py(WebAgg)toolmanager_sgskip.pysvg_histogram_sgskip.pysvg_tooltip_sgskip.pycanvasagg.pyEach example has a screenshot saved in
images/andsphinx_gallery_thumbnail_pathadded to its docstring.Closes #17479
AI Disclosure
No AI used.
PR Checklist