scripts/build-all-examples.bash (4)

8-16: Consider adding an explicit return statement.

SonarCloud flags the missing explicit return. While echo returns 0 on success, adding return 0 improves clarity.

Proposed fix

 usage() {
   echo "Usage: $0 [OPTIONS]"
   echo
   echo "Build all examples and display bundle sizes."
   echo
   echo "Options:"
   echo "  --list-size-only  Skip building, only display bundle sizes from existing dist/ directories"
   echo "  --help            Show this help message"
+  return 0
 }

---

46-52: Use [[ instead of [ for conditional tests.

SonarCloud flags this at line 49. The [[ construct is safer (handles word splitting and glob expansion automatically) and more feature-rich in bash.

Proposed fix

 # Infer examples that produce JS bundles (frontend applications only)
 EXAMPLES_FOR_TABLE=()
 for dir in packages/js-example* packages/ts-example*; do
-  if [ -d "$dir/dist" ] && find "$dir/dist" -name "*.js" -type f -print -quit | grep -q .; then
+  if [[ -d "$dir/dist" ]] && find "$dir/dist" -name "*.js" -type f -print -quit | grep -q .; then
     EXAMPLES_FOR_TABLE+=("$(basename "$dir")")
   fi
 done

---

75-85: Use [[ instead of [ for conditional tests.

SonarCloud flags this at line 79. Apply the same fix as suggested for line 49.

Proposed fix

 # Collect bundle sizes (largest JS file per example = the one containing maxGraph)
 declare -A BUNDLE_SIZES
 for example in "${EXAMPLES_FOR_TABLE[@]}"; do
   dir="packages/$example"
-  if [ -d "$dir/dist" ]; then
+  if [[ -d "$dir/dist" ]]; then
     BUNDLE_SIZES[$example]=$(find "$dir/dist" -name "*.js" -type f -exec ls -l {} \; | LC_NUMERIC=C awk '
       { if ($5 > max) max = $5 }
       END { printf "%.2f", max / 1000 }
     ')
   fi
 done

---

87-102: Use [[ instead of [ for conditional tests.

SonarCloud flags this at line 97. Apply the same fix for consistency.

Proposed fix

 for example in "${EXAMPLES_FOR_TABLE[@]}"; do
   size="${BUNDLE_SIZES[$example]:-}"
-  if [ -n "$size" ]; then
+  if [[ -n "$size" ]]; then
     echo "| $example | kB | $size kB |"
   else
     echo "| $example | kB | N/A |"
   fi
 done