Implementing get-enrollments, command queue inspection and deletion apis#239
Open
aakashjain2307 wants to merge 2 commits intomicromdm:mainfrom
Open
Implementing get-enrollments, command queue inspection and deletion apis#239aakashjain2307 wants to merge 2 commits intomicromdm:mainfrom
aakashjain2307 wants to merge 2 commits intomicromdm:mainfrom
Conversation
Add GET /v1/queue/{id} to retrieve queued commands for an enrollment
and DELETE /v1/queue/{id} to clear queued commands, with pagination
support and multi-ID delete. Implements storage backends for MySQL,
PostgreSQL, KV, file, and allmulti.
Member
|
Hey, sorry for the delay here! This is a .. very large PR (2300+ lines! yikes!), we're gonna need to split this up — I'd suggest first just the enrollment querying, then the queue inspection stuff. Further, I'd like to see testing and verification steps on example enrollments including test/verification output (e.g. Here's a nice guide: https://ieftimov.com/posts/how-to-make-reviewers-love-your-big-pull-requests/ and check out the example PRs they included. That's kinda what I'm looking for. :) Not only is the PR the code, the PR description really lays down the intent, philosophy, UX, high-level goal with the larger PR. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented get-enrollments, command queue inspection and deletion APIs as per the following drafts :-
#215
#214