Skip to content

Add a counter function example to verify the reuse-sandbox flag behavior#432

Open
anhdduong wants to merge 10 commits intoopen-lambda:mainfrom
anhdduong:my-openlambda-work
Open

Add a counter function example to verify the reuse-sandbox flag behavior#432
anhdduong wants to merge 10 commits intoopen-lambda:mainfrom
anhdduong:my-openlambda-work

Conversation

@anhdduong
Copy link
Copy Markdown
Contributor

Adds a counter example function and an integration test to verify that reuse-sandbox: false creates a fresh sandbox on each invocation.

Changes:

  • examples/counter/f.py: global counter that increments each call
  • examples/counter/ol.yaml: sets reuse-sandbox: false
  • scripts/test.py: fresh_sandbox_test() asserts counter always returns 1

Copy link
Copy Markdown
Member

@tylerharter tylerharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a lot of changes, and also it is failing the CI tests. Maybe you need to merge from main to your branch and push again?

I was hoping for, like, 3 files: f.py, ol.yaml, test.py. It's hard for me to tell what else you're changing before you merge, but if more things, perhaps it can be a separate PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants