Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: code-squad/javascript-amazon
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: pdvonzoo/javascript-amazon
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 73 files changed
  • 2 contributors

Commits on Jan 18, 2019

  1. Amazon 1, Step1&Step2 - 마크업 구현 (#26) 

    * Make css format

* Install npm modules & sass

* Update header top layout and style

* Add prime submit section

* Update css grid layout

* Add Static folder & Amazon amber font files

* Add carousel component

* Update prime detail layout

* Add prime delivery & prime video

* Add fixed navigation

* Add ship card animation

* Update fixed navigation

* Remove reset css file
    @pdvonzoo @crongro
    pdvonzoo authored and crongro committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    6b17500 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2019

  1. Amazon 1, Step3 - Plans 구현 (#44) 

    * Add plans structure

* [Add] 테스트 파일

* [setting] 웹팩 entry,output

* [setting]웹팩 css 로더

* [setting] html file 로더

* [setting]웹팩 html로더&babel

* [setting]웹팩 dist폴더로 번들링

* [update] Helpers의 테스트 코드

* [update] Plans sticky nav 온오프 메소드 구현

* [Add] Aspect class

* [Add] typeCollection Class&test code

* [Add] Registry class

* [Add] TypeDefinition - 인자, 반환값 타입 체크

* [Add] testHelper 추가

* [Refactoring] 토글 버튼 버그 수정

* [Remove] dist 폴더 삭제

* [Update] style 수정

* [Fix] 불필요한 style 제거

* [Fix] body style 수정
    @pdvonzoo @crongro
    pdvonzoo authored and crongro committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    89b18f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2019

  1. [Add] Carousel test, js file

    @pdvonzoo
    pdvonzoo committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    b2e843e View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. [Add] 캐러셀 이미지 ajax 요청 테스트 구현

    @pdvonzoo
    pdvonzoo committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    adaaf4c View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. [Add] ajax test

    @pdvonzoo
    pdvonzoo committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    4861011 View commit details
    Browse the repository at this point in the history

  2. [Update] helpers createEl 메소드 추가

    @pdvonzoo
    pdvonzoo committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    717d784 View commit details
    Browse the repository at this point in the history

  3. [Update] Carousel Dom test

    @pdvonzoo
    pdvonzoo committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    030f168 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2019

  1. [Update] Helpers에 checkType 메서드 추가

    @pdvonzoo
    pdvonzoo committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    0362fb8 View commit details
    Browse the repository at this point in the history

  2. [Refactoring] toString call 타입 체크 코드 리팩토링

    @pdvonzoo
    pdvonzoo committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    333fd7a View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. [Debugging] 이전 코드 변화로 인한 test code

    @pdvonzoo
    pdvonzoo committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    8ca200a View commit details
    Browse the repository at this point in the history

  2. [Update] Carousel Type check

    @pdvonzoo
    pdvonzoo committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    5cf184a View commit details
    Browse the repository at this point in the history

Commits on May 8, 2019

  1. Merge pull request #1 from pdvonzoo/step4 

    Feat: 싱크 조정
    @pdvonzoo
    pdvonzoo authored May 8, 2019
    Configuration menu
    Copy the full SHA
    348070a View commit details
    Browse the repository at this point in the history
Loading