[Windows] fix dllexport/dllimport mismatch with clang#21547
Closed
henderkes wants to merge 1 commit intophp:PHP-8.5from
Closed
[Windows] fix dllexport/dllimport mismatch with clang#21547henderkes wants to merge 1 commit intophp:PHP-8.5from
henderkes wants to merge 1 commit intophp:PHP-8.5from
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zend_closures.h defines this with ZEND_API (-> dllexport) while here it's defined without. leads to compilation error when using
--with-toolset=clangafter changing this, everything compiles correctly and is a drop-in replacement, except with better performance (thanks again to Arnaud!)
edit: actually, not quite yet. configure.js doesn't perform the HAVE_PRESERVE_NONE check. Incoming in another PR!