ci: Complete the unit test matrix#1324
Open
theofidry wants to merge 16 commits intophpbrew:masterfrom
Open
Conversation
This is a draft to show a bit of what I would like to see added in the CI: - A more complete matrix to run the tests on - A test build for the PHAR - E2E tests for the built PHAR
Contributor
Author
|
@peter279k should now be ready to review. Note that there is one failing test highlighted by the job, but in essence it already exists and should be fixed separately IMO. |
Contributor
Author
|
@peter279k rebased |
Draft
Member
|
Some tests are failed in the In the PHPUnit 8.5.33 by Sebastian Bergmann and contributors.
PHP Fatal error: Class 'Pimple\Container' not found in /home/runner/work/phpbrew/phpbrew/vendor/corneltek/cliframework/src/ServiceContainer.php on line 31In the box compile
make: box: No such file or directory
make: *** [Makefile:8: phpbrew] Error 127 |
Contributor
Author
|
@peter279k cleaned up the unnecessary stuff, it is green now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the matrix to run the unit tests on.