Fix: Prevent extra-options from being overwritten#1353
Open
PPP01 wants to merge 1 commit intophpbrew:masterfrom
Open
Fix: Prevent extra-options from being overwritten#1353PPP01 wants to merge 1 commit intophpbrew:masterfrom
PPP01 wants to merge 1 commit intophpbrew:masterfrom
Conversation
Member
|
Thanks for the PR. If possible, could you help me to add some unit tests to current Test classes in the |
Author
|
I'll try. But I have my difficulties with the unit tests because my dev-system does not have all needed dependencies |
|
This PR is still necessary to get extraoptions ending up correctly in the created PHP binary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extraoptions get partially overwritten:
--with-config-file-path
--with-config-file-scan-dir
This means that the additional inis are no longer loaded from the correct directory. If you have set up many php versions, then the config-file-scan-dir per version is not practical.
In version 1.27 the path was not yet overwritten and worked because it was appended at the end of the Makefile. Since v.1.28 the path is fixed in the code and there is no possibility to overwrite it.
With the patch, the extraoptions are split if necessary and then set correctly via withOption(option,value). Before the build, the system checks whether the two options are set.