ci: Leverage shivammathur/setup-php to install Box in the CI#1374
Open
theofidry wants to merge 3 commits intophpbrew:masterfrom
Open
ci: Leverage shivammathur/setup-php to install Box in the CI#1374theofidry wants to merge 3 commits intophpbrew:masterfrom
theofidry wants to merge 3 commits intophpbrew:masterfrom
Conversation
peter279k
reviewed
Jun 24, 2024
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '8.1' | ||
| php-version: '8.2' |
Member
There was a problem hiding this comment.
Is there any reason about changing 8.1 to the 8.2 version?
Contributor
Author
There was a problem hiding this comment.
Yes, newer versions of Box require PHP 8.2.
I don't expect it to cause issues though because the composer.json has the config.platform.php configured (it is set to PHP 7.2 so that we are on PHP 8.1 is already relying on this mechanism).
And I hope that if there is any issue, we could catch it via end-to-end tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires to upgrade the PHP version used for executing the PHAR building workflow to PHP 8.2 as the newest version of Box require PHP 8.2.