Open
Conversation
Introduces a workflow for the purpose of validating and reviewing the code. This where I would typically include: - Static analysis - Various validations, e.g. that the `composer.json` is valid (the only check currently implemented in this PR) - Code linting - Any unit tests that aim at checking the codebase architecture/structure/conventions, i.e. anything that is not testing the source code behaviour.
peter279k
reviewed
Jun 24, 2024
|
|
||
| on: | ||
| push: | ||
| branches: [ main, master ] |
Member
There was a problem hiding this comment.
Could you explain why the main branch is added in the branches setting?
Contributor
Author
There was a problem hiding this comment.
Currently, there is no reason.
I would like however to rename master to main at some point, allowing the two will allow to do that any time without any issue. Note that the other added workflow have the same too
Member
|
Thanks for your PR. I think the |
Contributor
Author
|
@peter279k clarified and extracted the composer update in #1379 |
Member
|
Due to the PR about updating the |
Contributor
Author
|
done |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a workflow for the purpose of validating and reviewing the code. This where I would typically include:
composer.jsonis valid (the only check currently implemented in this PR)