Conversation
|
It turned out that we still used box v3 which can't handle modern PHP code. I witched to v4, stumpled upon an issue ( box-project/box#1595). The main question is now if adding readonly to the classes is considered as a BC break. |
Workaround issue with broken scoper.inc.php integration in parallel mode
discordier
left a comment
There was a problem hiding this comment.
Only a small nitpick left.
I'd vote against treating the readonly as breaking change - they were intended to be immutable from the beginning and also were final, therefore they could not be overriden as writable.
| requirements: | ||
| box: | ||
| signed: false | ||
| version: ^3.15 |
There was a problem hiding this comment.
Should be restricted to ^4.0 now IMO, so we won't use a 5.x when it comes around.
There was a problem hiding this comment.
Shouldn't we then restrict the tool versions for each plugin?
There was a problem hiding this comment.
Only if they have inference with the code.
Like: Box, phpuniq, phpspec - all of these execute code or are extended by code within the repository.
No description provided.