Patches from FreeBSD ports - Recast booleans as bool for clarity.#95
Patches from FreeBSD ports - Recast booleans as bool for clarity.#95h6w merged 1 commit intophpvirtualbox:developfrom
Conversation
|
Hey. Thanks for the PR. Can you please include a link to where you got the patches, please? Cheers. |
|
Yeah. Can you split 8d4e71a into a separate PR? I feel it's muddying the PR request a little and is really a feature request we need to consider separately. Thanks! |
|
|
||
| public function reset() | ||
| { | ||
| // No password ID in case of decryption and de-/encryption are both handled here. |
There was a problem hiding this comment.
Sorry to be a pedant, but I'm curious about these 4 lines. They aren't simply recasting like the rest of the patch. These lines already exist in changeEncryption() and you're not blanking the vars like I'd expect in reset(). Is it possible that you've misapplied a patch? Can you explain this further?
There was a problem hiding this comment.
It is from ab70594
I merge together my changes with changes from other authors.
I will remove it.
There was a problem hiding this comment.
Yeah, that patch is patching changeEncryption(), which we have already done. Whereas your patch add these lines to reset(). See above.
|
Awesome. Thanks! |
More patches.
Bool conversions - for php update to 7x
"Clear on suspend" - was in FreeBSD ports