Skip to content
This repository was archived by the owner on Nov 4, 2020. It is now read-only.

get the comments of a commit in a project#260

Open
njzhaopei wants to merge 2 commits intopyapi-gitlab:developfrom
njzhaopei:get_repository_commit_comments
Open

get the comments of a commit in a project#260
njzhaopei wants to merge 2 commits intopyapi-gitlab:developfrom
njzhaopei:get_repository_commit_comments

Conversation

@njzhaopei
Copy link
Copy Markdown

This commit is used to get the comments of a commit in a project.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 7, 2017

Codecov Report

Merging #260 into develop will decrease coverage by 0.05%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #260      +/-   ##
===========================================
- Coverage    29.52%   29.46%   -0.06%     
===========================================
  Files            7        7              
  Lines          840      845       +5     
  Branches       156      157       +1     
===========================================
+ Hits           248      249       +1     
- Misses         592      596       +4
Impacted Files Coverage Δ
gitlab/__init__.py 19.73% <16.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74b6fb...a8bdd31. Read the comment docs.

@Sudo-Kid
Copy link
Copy Markdown
Contributor

Sudo-Kid commented Dec 6, 2017

Sorry for the long wait on a response to this. I would be happy to add this if you are willing to make some changes.

The method name is following the old pattern. All new methods should be updated to use an '_' in place of a space. This should be renamed to get_repository_commit_comments. We should also add *args, **kwargs to future proof it. There are also no tests for this PR so they will need to be added.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants