gh-146059: Cleanup pickle fast_save_enter() test#146481
gh-146059: Cleanup pickle fast_save_enter() test#146481vstinner merged 2 commits intopython:mainfrom
Conversation
Remove {"key": data}, it's not required to reproduce the bug.
Simplify also deep_nested_struct(): remove the seed parameter.
Fix a typo in a comment.
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Merged, thanks for reviewing Serhiy. |
Remove {"key": data}, it's not required to reproduce the bug.
Simplify also deep_nested_struct(): remove the seed parameter.
Fix a typo in a comment.
(cherry picked from commit 0c7a75a)
Co-authored-by: Victor Stinner <[email protected]>
|
GH-146509 is a backport of this pull request to the 3.14 branch. |
|
Sorry @vstinner, I had trouble completing the backport. |
|
Sorry, @vstinner, I could not cleanly backport this to |
|
Ah, the first backport is stuck because a test was failing on WASI: #146474. I fixed the test on WASI. I will backport this change to 3.13 once the first one is merged. |
…146509) gh-146059: Cleanup pickle fast_save_enter() test (GH-146481) Remove {"key": data}, it's not required to reproduce the bug. Simplify also deep_nested_struct(): remove the seed parameter. Fix a typo in a comment. (cherry picked from commit 0c7a75a) Co-authored-by: Victor Stinner <[email protected]>
|
It would be nice to have tests for recursive structures, to demonstrate that that mechanism works as expected. I suspect that |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Remove {"key": data}, it's not required to reproduce the bug.
Simplify also deep_nested_struct(): remove the seed parameter.
Fix a typo in a comment.
(cherry picked from commit 0c7a75a)
Co-authored-by: Victor Stinner <[email protected]>
|
GH-146510 is a backport of this pull request to the 3.13 branch. |
…146510) gh-146059: Cleanup pickle fast_save_enter() test (GH-146481) Remove {"key": data}, it's not required to reproduce the bug. Simplify also deep_nested_struct(): remove the seed parameter. Fix a typo in a comment. (cherry picked from commit 0c7a75a) Co-authored-by: Victor Stinner <[email protected]>
|
|
Remove {"key": data}, it's not required to reproduce the bug. Simplify also deep_nested_struct(): remove the seed parameter. Fix a typo in a comment.
Fatal Python errorwhen using_picklewith manyfrozensetobjects #146059