Open
Conversation
willingc
approved these changes
Mar 14, 2026
willingc
approved these changes
Mar 14, 2026
pfmoore
approved these changes
Mar 14, 2026
Contributor
Author
|
I think this would help uv. Recently, uv tried to fix a (really bad) bug: currently, it checks Dynamic: requires-dist
Requires-Dist: torch
Requires-Dist: einopswere not registering as dynamic, since Basically everything is listed in both in flash-attn!With this, and METADATA 2.6, you'd be able to treat the above as requiring at least |
Signed-off-by: Henry Schreiner <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
ef6eff0 to
8003740
Compare
Contributor
Author
|
@hugovk or @AA-Turner, hope you don't mind a little ping. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Henry Schreiner [email protected]
PEP 123: Summary of changes)This updates PEP 808 with a METADATA bump. This applies the same rules to METADATA that we are setting up for pyproject.toml. There was one potential downside: before, you could put any arbitrary metadata you wanted in METADATA if a field was marked as dynamic. After discussing this with @LecrisUT, we decided that was likely a reasonable restriction; there's not much you can do with this (if it's marked as dynamic, you need to compute it anyway if you have an SDist), and for all the fields present, it's not clear any of them would benefit from being "SDist-only" anyway.
@pfmoore needs to review/approve.
📚 Documentation preview 📚: https://pep-previews--4849.org.readthedocs.build/