Skip to content

Adding new ProjectHook attributes:#89

Merged
gpocentek merged 2 commits intopython-gitlab:masterfrom
ExodusIntelligence:master
Feb 6, 2016
Merged

Adding new ProjectHook attributes:#89
gpocentek merged 2 commits intopython-gitlab:masterfrom
ExodusIntelligence:master

Conversation

@d0c-s4vage
Copy link
Copy Markdown
Contributor

d0c-s4vage pushed a commit to ExodusIntelligence/python-gitlab that referenced this pull request Feb 4, 2016
two separate strings on different lines into one string.

see python-gitlab#89

will try to rebase pull request to include this.
@d0c-s4vage
Copy link
Copy Markdown
Contributor Author

lol build failed b/c:

git commit title ('Tricky-trickerson python gotcha here - forgotten comma turned two separate strings on different lines into one string.') should not end with period

hrmm

optionalCreateAttrs = ['push_events', 'issues_events',
'merge_requests_events', 'tag_push_events']
'merge_requests_events', 'tag_push_events',
'build_events', 'enable_ssl_verification']
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see build_events in the doc. I see note_events though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d0c-s4vage pushed a commit to ExodusIntelligence/python-gitlab that referenced this pull request Feb 4, 2016
two separate strings on different lines into one string

see python-gitlab#89

will try to rebase pull request to include this
@d0c-s4vage
Copy link
Copy Markdown
Contributor Author

hhhhhhhhh ok, I'll reword that commit again. Never knew there were such stringent restrictions on commit messages.

@gpocentek
Copy link
Copy Markdown
Contributor

I probably should ignore the commit message check, I agree it's a bit annoying.

gpocentek pushed a commit that referenced this pull request Feb 6, 2016
Adding new `ProjectHook` attributes:
@gpocentek gpocentek merged commit 81be3cf into python-gitlab:master Feb 6, 2016
@gpocentek
Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants