This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Open
Conversation
Update fork
Update branch
Template eval
runrevmark
reviewed
Oct 17, 2017
| static bool eval_async(MCExecContext& ctxt, MCExpression* p_expr, uinteger_t& r_value, Func &&remainder_function) __attribute__((noinline)) | ||
| { | ||
| uinteger_t t_value; | ||
| if (!MCEval_UIntType::eval_async(ctxt, p_expr, t_value, remainder_function)) |
Owner
There was a problem hiding this comment.
The thing to remember here is that you don't have the result of eval_async from UIntType until the remainder_function is called, so you need to make a remainder_function which does the value check and then passes to the remainder_function which was passed in.
Author
There was a problem hiding this comment.
But I think this particular eval shouldn't be async, because this is one of the intermediary steps of the whole thing, we delegate eval to process the current argument, and then give that to the continuation function. The only problem here could be if the eval triggers a wait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.