Open
Conversation
4ede19d to
45e3e9e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR対象
カテゴリ
PR の背景
仕様・動作説明
std::filesystem::existsをエラーコードを受け取らないモードで呼び出していて、エラー時にクラッシュしてしまう。周辺におかしいとこいっぱいありそうだけど対応は見送り。
元のコードにテストなかったのでテスト添付は断念。
本件、勝手にやります。
PR の影響範囲
テスト内容
関連 issue, PR
参考資料