Add support for external SSL certificates in upload methods.#141
Closed
mike1158 wants to merge 3 commits intoshotgunsoftware:masterfrom
Closed
Add support for external SSL certificates in upload methods.#141mike1158 wants to merge 3 commits intoshotgunsoftware:masterfrom
mike1158 wants to merge 3 commits intoshotgunsoftware:masterfrom
Conversation
added 2 commits
March 14, 2017 11:11
Note: Have tested that this works at our local site, but haven't
tested it with proxy connections.
I believe in Python <= 2.7.8 it simply doesn't validate the certificate at all, but the upload should still work. Now also honors the NO_SSL_VALIDATION setting.
|
I don't think the ci failed due to a problem with Mike's code; it's this: |
Author
|
Yeah, I just closed and re-opened this PR to trigger retrying the CI test. It still failed, but it doesn't look at all related to the PR. |
Contributor
|
Hey Mike, could you update with master, we just fixed our ci build. |
Author
|
Closing due to CI failures. Will re-create. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Have tested that this works at our local site, but haven't
tested it with proxy connections.